Skip to content

Add ban for pgp/gpg private key blocks to detect_private_key#329

Merged
asottile merged 1 commit intopre-commit:masterfrom
rpdelaney:feature/ban_gpg_private_key
Oct 22, 2018
Merged

Add ban for pgp/gpg private key blocks to detect_private_key#329
asottile merged 1 commit intopre-commit:masterfrom
rpdelaney:feature/ban_gpg_private_key

Conversation

@rpdelaney
Copy link
Contributor

@rpdelaney rpdelaney commented Oct 22, 2018

Adds ''BEGIN PGP PRIVATE KEY BLOCK" to the banlist for detect_private_key.py.

@asottile
Copy link
Member

asottile commented Oct 22, 2018

github is a mess, let me verify the tests locally

@asottile
Copy link
Member

asottile commented Oct 22, 2018 

  py27: commands succeeded
  py36: commands succeeded
  congratulations :)

@asottile asottile merged commit 86bfe8c into pre-commit:master Oct 22, 2018
@asottile
Copy link
Member

asottile commented Oct 22, 2018

🎉 thanks for the PR!

@rpdelaney rpdelaney mentioned this pull request Nov 21, 2018
Open
@joshuarli joshuarli mentioned this pull request Dec 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rpdelaney @asottile